feat: keep last 1000 log lines from modules #1348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last time I was reviewing Station module logs, I noticed they did not contain any messages from Spark, only messages from Voyager. Both modules produce rather verbose logs, which is good for troubleshooting, but requires us to keep more than 100 log lines. This commit increases the limit to 1000 lines. The performance impact should be negligible: assuming 100 bytes/line, the log storage will require ~100KiB of RAM. Signed-off-by: Miroslav Bajtoš <[email protected]>
juliangruber
approved these changes
Feb 21, 2024
|
Closing in favour of #1347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time I was reviewing Station module logs, I noticed they did not contain any messages from Spark, only messages from Voyager. Both modules produce rather verbose logs, which is good for troubleshooting, but requires us to keep more than 100 log lines.
This commit increases the limit to 1000 lines.
The performance impact should be negligible: assuming 100 bytes/line, the log storage will require ~100KiB of RAM.